netdev - Re: [PATCH net-next] ipv6: protect skb->sk accesses from recursive dereference inside the stack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 02 Apr 2015 12:24:40 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	hannes@...essinduktion.org
Cc:	eric.dumazet@...il.com, cwang@...pensource.com,
	netdev@...r.kernel.org, jiri@...nulli.us
Subject: Re: [PATCH net-next] ipv6: protect skb->sk accesses from recursive
 dereference inside the stack

From: Hannes Frederic Sowa <hannes@...essinduktion.org>
Date: Thu, 02 Apr 2015 13:34:08 +0200

> My plan is that I actually would propose this patch for -net and stable
> as it fixes the problem that currently we oops when running dhclient on
> a vxlan interface. As soon as net gets merged into net-next I I would
> propose this change if it works out smoothly and looks maintainable.

Yes, I think this patch is good for -net and -stable, but longer term we
have to do something better.

The most infuriating thing about this mess is that passing the tunnel
socket down is only difficult because of that damn okfn argument to
nf_hook().

And that is _only_ needed for nf_queue reinjection, absolutely nothing
else in the world uses it.

I can't believe how much of a price we pay for that feature :-/

So I've been trying to brainstorm a way to get rid of the okfn argument,
or somehow make adjustments to it's signature more painless.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html