lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 6 Apr 2015 14:13:12 -0700 From: Scott Feldman <sfeldma@...il.com> To: "Arad, Ronen" <ronen.arad@...el.com> Cc: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "jiri@...nulli.us" <jiri@...nulli.us>, "roopa@...ulusnetworks.com" <roopa@...ulusnetworks.com>, "linux@...ck-us.net" <linux@...ck-us.net>, "f.fainelli@...il.com" <f.fainelli@...il.com>, "Samudrala, Sridhar" <sridhar.samudrala@...el.com> Subject: Re: [PATCH net-next v3 19/26] switchdev: add new swdev_port_bridge_getlink On Sat, Apr 4, 2015 at 9:56 AM, Arad, Ronen <ronen.arad@...el.com> wrote: > > >>-----Original Message----- >>From: sfeldma@...il.com [mailto:sfeldma@...il.com] >>Sent: Thursday, April 02, 2015 1:10 AM >>To: netdev@...r.kernel.org >>Cc: jiri@...nulli.us; roopa@...ulusnetworks.com; linux@...ck-us.net; >>f.fainelli@...il.com; Samudrala, Sridhar; Arad, Ronen >>Subject: [PATCH net-next v3 19/26] switchdev: add new >>swdev_port_bridge_getlink >> >>From: Scott Feldman <sfeldma@...il.com> >> >>Like bridge_setlink, add swdev wrapper to handle bridge_getlink and call into >>port driver to get port attrs. For now, only BR_LEARNING and BR_LEARNING_SYNC >>are returned. To add more, we'll probably want to break away from >>ndo_dflt_bridge_getlink() and build the netlink skb directly in the swdev >>code. [cut] > > swdev_port_bridge_getlink and the function it wraps > ndo_dflt_bridge_getlink are only useful when all you need is to return > a set of brport attributes. > When a switchdev driver supports VLAN filtering without being enslaved > to a bridge this no longer works. ndo_dflt_bridge_getlink will end up in > a netlink RTM_NEWLINK message without the VLAN filtering info which is > maintained internally by the switchdev driver. > The driver will have to duplicate the code in ndo_dflt_bridge_getlink in > order to return a single RTM_NEWLINK message per port. > Can we break ndo_dflt_bridge_getlink to components that could be used > by such driver? > It would be useful to have one function that could fill the > IFLA_PROTINFO and another one for the IFLA_AF_SPEC. I couldn't find a consumer of the RTM_NEWLINK msg returned from RTM_GETLINK that wants the VLAN part of afspec. Did I miss one? -scott -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists