netdev - Re: [PATCH] rtlwifi: misspelled code and comments corrected.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 12 Apr 2015 11:26:10 -0500
From:	Larry Finger <Larry.Finger@...inger.net>
To:	Cheolhyun Park <pch851130@...il.com>, chaoming_li@...lsil.com.cn,
	kvalo@...eaurora.org, linville@...driver.com, Julia.Lawall@...6.fr
CC:	linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rtlwifi: misspelled code and comments corrected.

On 04/12/2015 11:04 AM, Cheolhyun Park wrote:
> Signed-off-by: Cheolhyun Park <pch851130@...il.com>

When you send a corrected patch, it is common to indicate that this is a 
corrected patch by putting the version number inside the [] in the subject, and 
to indicate the changes inside the patch, but after the --- line. Neither of 
these annotations will be included in the commit message, but they help the 
maintainer keep track of the patch, and whether you have satisfied the 
reviewer's comments. Thus this patch should have had the subject "[PATCH V2] 
rtlwifi: ..." and you should have had the lines below after the ---:
> ---

V2 - Fixed the typo introduced in V1 as noted by Julia Lawall.
---


>   drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c | 2 +-
>   drivers/net/wireless/rtlwifi/rtl8192de/dm.c       | 2 +-
>   drivers/net/wireless/rtlwifi/rtl8821ae/dm.c       | 2 +-
>   3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c b/drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c
> index f5ee67c..1273997 100644
> --- a/drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c
> +++ b/drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c
> @@ -312,7 +312,7 @@ static void rtl92c_dm_ctrl_initgain_by_rssi(struct ieee80211_hw *hw)
>   	struct dig_t *digtable = &rtlpriv->dm_digtable;
>   	u32 isbt;
>
> -	/* modify DIG lower bound, deal with abnorally large false alarm */
> +	/* modify DIG lower bound, deal with abnormally large false alarm */
>   	if (rtlpriv->falsealm_cnt.cnt_all > 10000) {
>   		digtable->large_fa_hit++;
>   		if (digtable->forbidden_igi < digtable->cur_igvalue) {
> diff --git a/drivers/net/wireless/rtlwifi/rtl8192de/dm.c b/drivers/net/wireless/rtlwifi/rtl8192de/dm.c
> index a1be5a6..f209cda 100644
> --- a/drivers/net/wireless/rtlwifi/rtl8192de/dm.c
> +++ b/drivers/net/wireless/rtlwifi/rtl8192de/dm.c
> @@ -420,7 +420,7 @@ static void rtl92d_dm_dig(struct ieee80211_hw *hw)
>   		 "dm_DIG() Before: Recover_cnt=%d, rx_gain_min=%x\n",
>   		 de_digtable->recover_cnt, de_digtable->rx_gain_min);
>
> -	/* deal with abnorally large false alarm */
> +	/* deal with abnormally large false alarm */
>   	if (falsealm_cnt->cnt_all > 10000) {
>   		RT_TRACE(rtlpriv, COMP_DIG, DBG_LOUD,
>   			 "dm_DIG(): Abnormally false alarm case\n");
> diff --git a/drivers/net/wireless/rtlwifi/rtl8821ae/dm.c b/drivers/net/wireless/rtlwifi/rtl8821ae/dm.c
> index 0b2082d..342678d 100644
> --- a/drivers/net/wireless/rtlwifi/rtl8821ae/dm.c
> +++ b/drivers/net/wireless/rtlwifi/rtl8821ae/dm.c
> @@ -873,7 +873,7 @@ static void rtl8821ae_dm_dig(struct ieee80211_hw *hw)
>
>   	if (rtlpriv->falsealm_cnt.cnt_all > 10000) {
>   		RT_TRACE(rtlpriv, COMP_DIG, DBG_LOUD,
> -			 "Abnornally false alarm case.\n");
> +			 "Abnormally false alarm case.\n");
>
>   		if (dm_digtable->large_fa_hit != 3)
>   			dm_digtable->large_fa_hit++;
>

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html