netdev - Re: [PATCH v4 4/9] bgmac: simplify rx DMA error handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 13 Apr 2015 16:53:46 +0200
From:	Rafał Miłecki <zajec5@...il.com>
To:	Felix Fietkau <nbd@...nwrt.org>
Cc:	Network Development <netdev@...r.kernel.org>,
	Hauke Mehrtens <hauke@...ke-m.de>
Subject: Re: [PATCH v4 4/9] bgmac: simplify rx DMA error handling

On 13 April 2015 at 15:52, Felix Fietkau <nbd@...nwrt.org> wrote:
> Unmap the DMA buffer before checking it. If it is poisoned, map it again
> and pass it back to the hardware.

Where exactly do you map it again? I can't see it. It's not handled in
bgmac_dma_rx_setup_desc. Also keep in mind that mapping may fail -
this is why old code doesn't unmap anything until a new buffer is
really ready. How do you want to deal with mapping error after
unmapping a buffer?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html