netdev - Re: [PATCH resend] Renesas Ethernet AVB driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 13 Apr 2015 23:34:17 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Ben Hutchings <ben.hutchings@...ethink.co.uk>
CC:	robh+dt@...nel.org, pawel.moll@....com, mark.rutland@....com,
	ijc+devicetree@...lion.org.uk, devicetree@...r.kernel.org,
	galak@...eaurora.org, netdev@...r.kernel.org,
	linux-sh@...r.kernel.org
Subject: Re: [PATCH resend] Renesas Ethernet AVB driver

Hello.

On 04/02/2015 04:56 PM, Ben Hutchings wrote:

> This driver looks somewhat similar to sh-eth, but lacks some of the
> recent bug fixes made to that.  At least commit 283e38db65e7 ("sh_eth:
> Fix serialisation of interrupt disable with interrupt & NAPI handler")
> appears to be applicable, but there are probably others.

    I suspect this issue applies to many drivers...
    I couldn't reproduce the bug that patch was fixing, so left this fix out 
for the time being. Others cases were fixed (if applicable).

> One feature request:

> On Sat, 2015-03-28 at 02:13 +0300, Sergei Shtylyov wrote:
> [...]
>> +/* ioctl to device function */
>> +static int ravb_do_ioctl(struct net_device *ndev, struct ifreq *req, int cmd)
>> +{
>> +	struct ravb_private *priv = netdev_priv(ndev);
>> +	struct phy_device *phydev = priv->phydev;
>> +
>> +	if (!netif_running(ndev))
>> +		return -EINVAL;
>> +
>> +	if (!phydev)
>> +		return -ENODEV;
>> +
>> +	if (cmd == SIOCSHWTSTAMP)
>> +		return ravb_hwtstamp_ioctl(ndev, req, cmd);
> [...]

> The driver should also handle SIOCGHWTSTAMP.

    Done.

> Ben.

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html