lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 14 Apr 2015 02:05:18 +0200 From: Felix Fietkau <nbd@...nwrt.org> To: David Miller <davem@...emloft.net>, romieu@...zoreil.com CC: netdev@...r.kernel.org, zajec5@...il.com, hauke@...ke-m.de Subject: Re: [PATCH v5 4/9] bgmac: simplify rx DMA error handling On 2015-04-14 02:04, David Miller wrote: > From: Francois Romieu <romieu@...zoreil.com> > Date: Tue, 14 Apr 2015 01:20:40 +0200 > >> Felix Fietkau <nbd@...nwrt.org> : >>> Unmap the DMA buffer before checking it. If an error occurs, free the >>> buffer and allocate a new one. If allocation or mapping fails, retry as >>> long as there is NAPI poll budget left (count every attempt instead of >>> every frame). >> >> The driver is not supposed to use the NAPI budget this way. >> >> If the driver can't reserve resources to handle the packet, it should >> drop the data, keep everything in place for the hardware and move to the >> next slot. > > +1 Fixed in v6. - Felix -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists