netdev - Re: [PATCH] ip_forward: Drop frames with attached skb->sk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 14 Apr 2015 14:33:32 +0800
From:	yzhu1 <Yanjun.Zhu@...driver.com>
To:	Sebastian Poehn <sebastian.poehn@...il.com>,
	David Miller <davem@...emloft.net>
CC:	<netdev@...r.kernel.org>, <fw@...len.de>, <eric.dumazet@...il.com>
Subject: Re: [PATCH] ip_forward: Drop frames with attached skb->sk

On 04/14/2015 01:52 PM, Sebastian Poehn wrote:
> Initial discussion was:
> [FYI] xfrm: Don't lookup sk_policy for timewait sockets
>
> Forwarded frames should not have a socket attached. Especially
> tw sockets will lead to panics later-on in the stack.
>
> This was observed with TPROXY assigning a tw socket and broken
> policy routing (misconfigured). As a result frame enters
> forwarding path instead of input. We cannot solve this in
> TPROXY as it cannot know that policy routing is broken.
>
> Signed-off-by: Sebastian Poehn <sebastian.poehn@...il.com>
> ---
> diff --git a/net/ipv4/ip_forward.c b/net/ipv4/ip_forward.c
> index 939992c..2fc3b3e 100644
> --- a/net/ipv4/ip_forward.c
> +++ b/net/ipv4/ip_forward.c
> @@ -82,6 +82,10 @@ int ip_forward(struct sk_buff *skb)
>   	if (skb->pkt_type != PACKET_HOST)
>   		goto drop;
>   
> +	/* this should happen neither */
Sorry. "neither" should be "either"?

Zhu Yanjun
> +	if (unlikely(skb->sk))
> +		goto drop;
> +
>   	if (skb_warn_if_lro(skb))
>   		goto drop;
> --
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html