| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Wed, 15 Apr 2015 18:22:29 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: Nicolas Dichtel <nicolas.dichtel@...nd.com>
Cc: netdev@...r.kernel.org, "Eric W. Biederman" <ebiederm@...ssion.com>
Subject: Re: ip_tunnel: Remove gratuitous skb scrubbing
On Wed, Apr 15, 2015 at 12:20:42PM +0200, Nicolas Dichtel wrote:
> Le 15/04/2015 12:01, Herbert Xu a écrit :
> >The commit ea23192e8e577dfc51e0f4fc5ca113af334edff9 ("tunnels:
> >harmonize cleanup done on skb on rx path") broke anyone trying to
> >use netfilter marking across IPv4 tunnels. As the commit message
> >did not give any justification for this (in fact it shouldn't
> >even be touching the tx path), I can only assume that it was a typo.
> If I remember well, this was discussed on netdev (CC Eric). The goal of this
> patch was, like the title said, to hamonize packets processing in tunnels.
> I'm not against to keep the mark, but I think patching skb_scrub_packet is
> better. With your patch, ip6tnl, gre6, etc. still drops the mark. And at the
> end, it's not consistant.
>
> What about something like this:
Yes this is better. I'm currently auditing all the other bits
that are cleared to see if there is anything else that we should
preserve for tunneling.
Cheers,
--
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists