lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 15 Apr 2015 12:44:23 +0000 From: David Laight <David.Laight@...LAB.COM> To: 'Alexander Duyck' <alexander.duyck@...il.com>, Pablo Neira Ayuso <pablo@...filter.org>, "netfilter-devel@...r.kernel.org" <netfilter-devel@...r.kernel.org> CC: "kaber@...sh.net" <kaber@...sh.net>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "davem@...emloft.net" <davem@...emloft.net> Subject: RE: [PATCH 1/7] net: refactor __netif_receive_skb_core From: Alexander Duyck > Sent: 10 April 2015 20:56 > On 04/10/2015 05:15 AM, Pablo Neira Ayuso wrote: > > +another_round: > > + ret = __netif_receive_skb_ingress(skb, pfmemalloc, orig_dev); > > + switch (ret) { > > + case NET_RX_SUCCESS: > > + case NET_RX_DROP: > > + break; > > + case __NET_RX_ANOTHER_ROUND: > > + goto another_round; > > + } > > rcu_read_unlock(); > > + > > return ret; > > } > > > > > > Couldn't this just be done as a do while? It would probably be easier > to read and there wouldn't be any need for the another_round label anymore. Or an infinite loop with a break at the bottom, as in: for (;;) { switch (...) { case again: continue; default: break; } break; } David -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists