lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 16 Apr 2015 14:25:26 +0800 From: Ding Tianhong <dingtianhong@...wei.com> To: Arnd Bergmann <arnd@...db.de> CC: <davem@...emloft.net>, <grant.likely@...aro.org>, <sergei.shtylyov@...entembedded.com>, <linux-arm-kernel@...ts.infradead.org>, <eric.dumazet@...il.com>, <zhangfei.gao@...aro.org>, <joe@...ches.com>, <netdev@...r.kernel.org>, <devicetree@...r.kernel.org>, <linux@....linux.org.uk> Subject: Re: [PATCH net-next 2/6] net: hip04: use the big endian for tx and rx desc On 2015/4/15 22:13, Arnd Bergmann wrote: > On Wednesday 15 April 2015 20:30:04 Ding Tianhong wrote: >> The hip04 ethernet use the big endian for tx and rx, so set desc to >> big endian and remove the unused next_addr. > > I don't understand: > >> diff --git a/drivers/net/ethernet/hisilicon/hip04_eth.c b/drivers/net/ethernet/hisilicon/hip04_eth.c >> index b0a7f03..6473462 100644 >> --- a/drivers/net/ethernet/hisilicon/hip04_eth.c >> +++ b/drivers/net/ethernet/hisilicon/hip04_eth.c >> @@ -132,19 +132,18 @@ >> #define HIP04_MIN_TX_COALESCE_FRAMES 1 >> >> struct tx_desc { >> - u32 send_addr; >> - u32 send_size; >> - u32 next_addr; >> - u32 cfg; >> - u32 wb_addr; >> + __be32 send_addr; >> + __be32 send_size; >> + __be32 cfg; >> + __be32 wb_addr; >> } __aligned(64); > > I would think this is a hardware structure, does this not break > access to the cfg and wb_addr fields if you remove next_addr? > > Arnd > good cache, I make a mistake here, thanks. > . > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists