netdev - Re: [patch 1/1] cxgb4: drop __GFP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 16 Apr 2015 12:03:26 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	akpm@...ux-foundation.org
Cc:	hariprasad@...lsio.com, netdev@...r.kernel.org, mhocko@...e.cz,
	david@...morbit.com, hannes@...xchg.org, jack@...e.cz,
	mgorman@...e.de, penguin-kernel@...ove.SAKURA.ne.jp,
	rientjes@...gle.com, tytso@....edu
Subject: Re: [patch 1/1] cxgb4: drop __GFP_NOFAIL allocation

From: akpm@...ux-foundation.org
Date: Tue, 14 Apr 2015 13:24:33 -0700

> From: Michal Hocko <mhocko@...e.cz>
> Subject: cxgb4: drop __GFP_NOFAIL allocation
> 
> set_filter_wr is requesting __GFP_NOFAIL allocation although it can return
> ENOMEM without any problems obviously (t4_l2t_set_switching does that
> already).  So the non-failing requirement is too strong without any
> obvious reason.  Drop __GFP_NOFAIL and reorganize the code to have the
> failure paths easier.
> 
> The same applies to _c4iw_write_mem_dma_aligned which uses __GFP_NOFAIL
> and then checks the return value and returns -ENOMEM on failure.  This
> doesn't make any sense what so ever.  Either the allocation cannot fail or
> it can.
> 
> del_filter_wr seems to be safe as well because the filter entry is not
> marked as pending and the return value is propagated up the stack up to
> c4iw_destroy_listen.
> 
> Signed-off-by: Michal Hocko <mhocko@...e.cz>
 ...
> Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html