netdev - Re: [PATCH v2 net-next] ip: Add color output option

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 20 Apr 2015 10:16:02 -0700
From:	Stephen Hemminger <stephen@...workplumber.org>
To:	Mathias Nyman <m.nyman@....fi>
Cc:	netdev@...r.kernel.org, daniel@...earbox.net,
	alexei.starovoitov@...il.com, aleksi.aalto@....fi
Subject: Re: [PATCH v2 net-next] ip: Add color output option

On Sat, 18 Apr 2015 13:39:45 +0300
Mathias Nyman <m.nyman@....fi> wrote:

> It is hard to quickly find what you are looking for in the output of
> the ip
> command. Color helps.
> 
> This patch adds a '-c' flag to highlight these with individual colors:
>    - interface name
>    - ip address
>    - mac address
>    - up/down state
> 
> Signed-off-by: Mathias Nyman <m.nyman@....fi>

I like the idea of this, it would be generally good across the board.

But the patch does not apply cleanly to the current version of iproute2.

And there are minor style issues. iproute2 in general ties to follow kernel style.

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#36: 
new file mode 100644

ERROR: open brace '{' following enum go on the same line
#45: FILE: include/color.h:5:
+enum color_attr
+{

ERROR: open brace '{' following enum go on the same line
#195: FILE: lib/color.c:7:
+enum color
+{

ERROR: that open brace { should be on the previous line
#207: FILE: lib/color.c:19:
+static const char * const color_codes[] =
+{

ERROR: that open brace { should be on the previous line
#220: FILE: lib/color.c:32:
+static enum color attr_colors[] =
+{

ERROR: do not initialise statics to 0 or NULL
#229: FILE: lib/color.c:41:
+static int color_is_enabled = 0;

WARNING: Missing a blank line after declarations
#240: FILE: lib/color.c:52:
+	va_list args;
+	va_start(args, fmt);


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html