netdev - RE: [PATCH iproute2 1/3] tc: fix compilation warning on 32bits arch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 21 Apr 2015 16:22:32 +0000
From:	David Laight <David.Laight@...LAB.COM>
To:	'Nicolas Dichtel' <nicolas.dichtel@...nd.com>,
	"shemminger@...tta.com" <shemminger@...tta.com>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [PATCH iproute2 1/3] tc: fix compilation warning on 32bits arch

From: Nicolas Dichtel
> Sent: 21 April 2015 17:07
> The warning was:
> m_simple.c: In function parse_simple:
> m_simple.c:142:4: warning: format %ld expects argument of type long int, but argument 3 has type
> size_t [-Wformat]
> 
> Useful to be able to compile with -Werror.
> 
> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@...nd.com>
> ---
>  tc/m_simple.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tc/m_simple.c b/tc/m_simple.c
> index 866552f559b3..3b6d7beb769c 100644
> --- a/tc/m_simple.c
> +++ b/tc/m_simple.c
> @@ -139,7 +139,7 @@ parse_simple(struct action_util *a, int *argc_p, char ***argv_p, int tca_id,
> 
>  	if (strlen(simpdata) > (SIMP_MAX_DATA - 1)) {
>  		fprintf(stderr, "simple: Illegal string len %ld <%s> \n",
> -			strlen(simpdata), simpdata);
> +			(long)strlen(simpdata), simpdata);
>  		return -1;

Isn't the correct fix to use "%zu" ?

	David