lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 21 Apr 2015 20:30:13 -0400 (EDT) From: David Miller <davem@...emloft.net> To: sixiao@...rosoft.com Cc: kys@...rosoft.com, haiyangz@...rosoft.com, devel@...uxdriverproject.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH net-next,1/1] hv_netvsc: call dump_rndis_message() only in netvsc debug mode From: Simon Xiao <sixiao@...rosoft.com> Date: Tue, 21 Apr 2015 22:14:14 +0000 > In current netvsc driver, for each packet received, it will call > dump_rndis_message() to try to dump the rndis packet information by > netdev_dbg(). In non-debug mode, dump_rndis_message() will not dump > anything but it still initialize some local variables and process > the switch logic in the function of dump_rndis_message(), which is > unnecessary, especially in high network throughput situation. See NETIF_MSG_* and use it properly in your driver, read other drivers and learn how to properly use it for things like this. I'm not going to explain this a third time. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists