netdev - Re: [PATCH 0/3] mpls: ABI changes for security and correctness

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 22 Apr 2015 11:10:38 +0100
From:	Robert Shearman <rshearma@...cade.com>
To:	"Eric W. Biederman" <ebiederm@...ssion.com>
CC:	"davem@...emloft.net" <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH 0/3] mpls: ABI changes for security and correctness

On 22/04/15 01:29, Eric W. Biederman wrote:
> Robert Shearman <rshearma@...cade.com> writes:
>
>> These changes make mpls not be enabled by default on all
>> interfaces when in use for security, along with ensuring that a label
>> not valid as an outgoing label can be added in mpls routes.
>>
>> This series contains three ABI/behaviour-affecting changes which have
>> been split out from "[PATCH net-next v4 0/6] mpls: Behaviour-changing
>> improvements" without any further modification. These changes need to
>> be considered for 4.1 otherwise we'll be stuck with the current
>> behaviour/ABI forever.
>
> I don't like the difference in default between loopback and everything
> else.  That just seems like an extra arbitrary rule.

Ok, I'll get rid of that.

>
> Otherwise:
> Acked-by: "Eric W. Biederman" <ebiederm@...ssion.com>
>
> Not that I expect Dave Miller is taking patches during the merge window.
>
>> Robert Shearman (3):
>>    mpls: Per-device MPLS state
>>    mpls: Per-device enabling of packet input
>>    mpls: Prevent use of implicit NULL label as outgoing label
>>
>>   Documentation/networking/mpls-sysctl.txt |   9 +++
>>   include/linux/netdevice.h                |   4 +
>>   net/mpls/af_mpls.c                       | 132 ++++++++++++++++++++++++++++++-
>>   net/mpls/internal.h                      |   6 ++
>>   4 files changed, 148 insertions(+), 3 deletions(-)
>
> Eric
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html