lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 21 Apr 2015 20:31:34 -0400 (EDT) From: David Miller <davem@...emloft.net> To: michael@...rulasolutions.com Cc: peppe.cavallaro@...com, festevam@...il.com, netdev@...r.kernel.org Subject: Re: [PATCH V2] net: stmmac: use msleep instead of udelay for gpio reset From: Michael Trimarchi <michael@...rulasolutions.com> Date: Wed, 22 Apr 2015 01:13:47 +0200 > Hi > > On Tue, Apr 21, 2015 at 05:35:40PM -0400, David Miller wrote: >> From: Michael Trimarchi <michael@...rulasolutions.com> >> Date: Tue, 21 Apr 2015 13:16:13 +0200 >> >> > - udelay(data->delays[0]); >> ... >> > + msleep(max(1U, data->delays[0] / 1000)); >> >> That looks very ugly with that max() expression in there. >> > > Is fine for you a DIV_ROUND_UP? Not inside of these simple msleep() calls, no. How about adjusting the values either in the datastructure or in local variables instead? That wasn't so hard to come up with now, was it? -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists