lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 27 Apr 2015 23:14:21 -0400 (EDT) From: David Miller <davem@...emloft.net> To: Yuval.Mintz@...gic.com Cc: mschmidt@...hat.com, netdev@...r.kernel.org, Dmitry.Kravkov@...gic.com, Ariel.Elior@...gic.com Subject: Re: [PATCH net] bnx2x: really disable TPA if 'disable_tpa' option is set From: Yuval Mintz <Yuval.Mintz@...gic.com> Date: Mon, 27 Apr 2015 18:15:44 +0000 >>> bnx2x's 'disable_tpa=1' module option is not respected properly and TPA >>> (transparent packet aggregation) remains enabled. Even though the >>> module option causes LRO to be disabled, TPA is enabled in GRO mode. >>> >>> Additionally, disabling GRO via ethtool then has no effect. One can >>> still observe tpa_* statistics increase and large packets being received >>> in tcpdump. >>> >>> The bug was an unintended consequence of commit aebf6244cd39 "bnx2x: Be >>> more forgiving toward SW GRO". >>> >>> Fix it by following the bp->disable_tpa flag when initializing fp's. >>> >>> Signed-off-by: Michal Schmidt <mschmidt@...hat.com> >> >>Applied, thanks. > > Michal - thanks, but Dave -is it possible you gave us only 2.5 hours to > review this one? You'll need to send me a revert or changes relative to this one as the commit is not only permanent when it reaches my tree, it's also made it's way into Linus's tree now as well. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists