netdev - Re: [PATCH v2] bnx2x: Alloc 4k fragment for each rx ring buffer element

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 30 Apr 2015 16:05:37 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	Yuval.Mintz@...gic.com
Cc:	krisman@...ux.vnet.ibm.com, LinoSanfilippo@....de,
	Ariel.Elior@...gic.com, netdev@...r.kernel.org,
	cascardo@...ux.vnet.ibm.com, cascardo@...cardo.eti.br,
	brking@...ux.vnet.ibm.com
Subject: Re: [PATCH v2] bnx2x: Alloc 4k fragment for each rx ring buffer
 element

From: Yuval Mintz <Yuval.Mintz@...gic.com>
Date: Thu, 30 Apr 2015 11:25:31 +0000

>> +struct bnx2x_alloc_pool {
>> +	struct page	*page;
>> +	dma_addr_t	dma;
>> +	int		len;
> 
> Isn't len always set to PAGE_SIZE? If so it can be dropped

Agreed, len appears unnecessary.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html