netdev - Re: [RFC PATCH net-next v3 6/9] ipv6: Set FLOWI_FLAG_KNOWN_NH at flowi6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 2 May 2015 15:21:06 +0300 (EEST)
From:	Julian Anastasov <ja@....bg>
To:	Martin KaFai Lau <kafai@...com>
cc:	netdev <netdev@...r.kernel.org>,
	Hannes Frederic Sowa <hannes@...essinduktion.org>,
	Steffen Klassert <steffen.klassert@...unet.com>,
	David Miller <davem@...emloft.net>,
	Kernel Team <Kernel-team@...com>
Subject: Re: [RFC PATCH net-next v3 6/9] ipv6: Set FLOWI_FLAG_KNOWN_NH at
 flowi6_flags


	Hello,

On Fri, 1 May 2015, Martin KaFai Lau wrote:

> The neighbor look-up used to depend on the rt6i_gateway (if
> there is a gateway) or the rt6i_dst (if it is a RTF_CACHE clone)
> as the nexthop address.  Note that rt6i_dst is set to fl6->daddr
> for the RTF_CACHE clone where fl6->daddr is the one used to do
> the route look-up.
> 
> Now, we only create RTF_CACHE clone after encountering exception.
> When doing the neighbor look-up with a route that is neither a gateway
> nor a RTF_CACHE clone, the daddr in skb will be used as the nexthop.
> 
> In some cases, the daddr in skb is not the one used to do
> the route look-up.  One example is in ip_vs_dr_xmit_v6() where the
> real nexthop server address is different from the one in the skb.
> 
> This patch is going to follow the IPv4 approach and ask the
> ip6_pol_route() callers to set the FLOWI_FLAG_KNOWN_NH properly.
> 
> In the next patch, ip6_pol_route() will honor the FLOWI_FLAG_KNOWN_NH
> and create a RTF_CACHE clone.
> 
> Signed-off-by: Martin KaFai Lau <kafai@...com>
> Cc: Hannes Frederic Sowa <hannes@...essinduktion.org>
> Cc: Steffen Klassert <steffen.klassert@...unet.com>
> Cc: Julian Anastasov <ja@....bg>

	I applied all 9 patches to net-next and tested
IPVS-DR. We are properly resolving the nexthop saved in
route. Then I commented the FLOWI_FLAG_KNOWN_NH flag
in IPVS and checked that daddr from packet was used. As
expected, DR metod fails here. So, the new flag appears
to work correctly.

	I didn't analyzed the IPv6 changes but the
IPVS changes look good to me:

Acked-by: Julian Anastasov <ja@....bg>
Tested-by: Julian Anastasov <ja@....bg>

Thanks!

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html