lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 3 May 2015 17:42:08 +0200 From: Jesper Dangaard Brouer <brouer@...hat.com> To: Alexei Starovoitov <ast@...mgrid.com> Cc: brouer@...hat.com, "David S. Miller" <davem@...emloft.net>, John Fastabend <john.r.fastabend@...el.com>, Jamal Hadi Salim <jhs@...atatu.com>, Daniel Borkmann <daniel@...earbox.net>, netdev@...r.kernel.org Subject: Re: [PATCH v2 net-next] net: sched: run ingress qdisc without locks On Fri, 1 May 2015 22:27:28 -0700 Alexei Starovoitov <ast@...mgrid.com> wrote: > From: John Fastabend <john.r.fastabend@...el.com> > > TC classifiers/actions were converted to RCU by John in the series: > http://thread.gmane.org/gmane.linux.network/329739/focus=329739 > and many follow on patches. > This is the last patch from that series that finally drops > ingress spin_lock. I absolutely love this change. It is a huge step for ingress scalability. > Single cpu ingress+u32 performance goes from 22.9 Mpps to 24.5 Mpps. I was actually expecting to see a higher performance boost. (processing cost per packet) (1/(22.9*10^6)*10^9) = 43.67 ns (1/(24.5*10^6)*10^9) = 40.82 ns improvement diff = -2.85 ns The patch is removing two atomic operations, spin_{un,}lock, which I have benchmarked[1] to cost approx 14ns on my system. Your system likely is faster, but not that much (p.s. benchmark your own system with [1]) [1] https://github.com/netoptimizer/prototype-kernel/blob/master/kernel/lib/time_bench_sample.c > In two cpu case when both cores are receiving traffic on the same > device and go into the same ingress+u32 the performance jumps > from 4.5 + 4.5 Mpps to 23.5 + 23.5 Mpps This looks good for scalability :-))) > Signed-off-by: John Fastabend <john.r.fastabend@...el.com> > Signed-off-by: Alexei Starovoitov <ast@...mgrid.com> > Signed-off-by: Jamal Hadi Salim <jhs@...atatu.com> > Acked-by: Daniel Borkmann <daniel@...earbox.net> Acked-by: Jesper Dangaard Brouer <brouer@...hat.com> -- Best regards, Jesper Dangaard Brouer MSc.CS, Sr. Network Kernel Developer at Red Hat Author of http://www.iptv-analyzer.org LinkedIn: http://www.linkedin.com/in/brouer -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists