netdev - Re: [PATCH net-next 05/10] be2net: don't enable PAUSE by default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 04 May 2015 11:59:57 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	sathya.perla@...lex.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next 05/10] be2net: don't enable PAUSE by default

From: Sathya Perla <sathya.perla@...lex.com>
Date: Mon,  4 May 2015 02:47:17 -0400

> From: Kalesh AP <kalesh.purayil@...lex.com>
> 
> The driver so far, on load, always tried to enable RX/TX general pause.
> This setting always fails on certain profiles (like FCoE) where PFC is
> needed. Such failures cannot be effectively communicated to the stack or
> user. To fix this unpredictability in state, this patch changes the driver
> behavior by not configuring pause at load time.
> The user can configure it via ethtool and if the setting is disallowed,
> an appropriate error is returned.
> 
> Signed-off-by: Kalesh AP <kalesh.purayil@...lex.com>
> Signed-off-by: Sathya Perla <sathya.perla@...lex.com>

Not enabling pause by default is going to be _STRONGLY_ not expected
by the user and will cause unwanted packet drops in high traffic
environments.

It's not the user's fault that your stuff is architected in such a way
such that handling this properly isn't easy.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html