netdev - Re: [RFC PATCH net-next 1/8] net: dsa: Move dsa_switch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 03 May 2015 22:01:20 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	f.fainelli@...il.com
Cc:	netdev@...r.kernel.org, vivien.didelot@...oirfairelinux.com,
	jerome.oufella@...oirfairelinux.com, linux@...ck-us.net,
	andrew@...n.ch, cphealy@...il.com, mathieu@...eaurora.org,
	jonasj76@...il.com, andrey.volkov@...vision.fr,
	Chris.Packham@...iedtelesis.co.nz
Subject: Re: [RFC PATCH net-next 1/8] net: dsa: Move dsa_switch_tree final
 setup in separate function

From: Florian Fainelli <f.fainelli@...il.com>
Date: Wed, 29 Apr 2015 18:57:37 -0700

> +static void dsa_setup_dst_end(struct net_device *dev, struct dsa_switch_tree *dst)
> +{
> +	/*
> +	 * If we use a tagging format that doesn't have an ethertype
> +	 * field, make sure that all packets from this point on get
> +	 * sent to the tag format's receive function.
> +	 */
> +	wmb();
> +	dev->dsa_ptr = (void *)dst;

I know you're just moving code, but this cast seems pointless to me.

dev->dsa_ptr is of type "struct dsa_switch_tree".
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html