netdev - Re: [PATCH -next 4/5] net: sched: remove AT INGRESS/EGRESS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 5 May 2015 13:11:32 +0200
From:	Florian Westphal <fw@...len.de>
To:	Daniel Borkmann <daniel@...earbox.net>
Cc:	Florian Westphal <fw@...len.de>, netdev@...r.kernel.org,
	jhs@...atatu.com, alexei.starovoitov@...il.com
Subject: Re: [PATCH -next 4/5] net: sched: remove AT INGRESS/EGRESS

Daniel Borkmann <daniel@...earbox.net> wrote:
> On 05/04/2015 08:48 PM, Florian Westphal wrote:
> >use single marker to propagate location.
> >tc_at_ingress 1: ingress, 0 is egress.
> >
> >The new flag is set/unset in sch_ingress instead of the core.
> >We will also no longer set skb->tc_verd to AT_EGRESS in the xmit
> >handler.
> >
> >Signed-off-by: Florian Westphal <fw@...len.de>
> ...
> >diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
> >index 911d84e..d794077 100644
> >--- a/include/linux/skbuff.h
> >+++ b/include/linux/skbuff.h
> >@@ -488,6 +488,7 @@ static inline u32 skb_mstamp_us_delta(const struct skb_mstamp *t1,
> >   *	@queue_mapping: Queue mapping for multiqueue devices
> >   *	@xmit_more: More SKBs are pending for this queue
> >   *	@tc_from_ingress: skb is processed during rx, not transmit
> >+ *	@tc_at_ingress: skb is processed during rx, not transmit
> 
> Minor nit:
> 
> I think both comments needs to be a bit more clear. I.e. tc_at_ingress
> tells the *current* location whether we are invoked from ingress or
> egress. And, tc_from_ingress explains the *previous* location, whether
> the skbs has been mirred from ingress path or egress path.

Agree, the reason is that I tried to go with single tc_ingress:1 but it
turned out to be not as trivial as I thought.

I'll fix it up in v2, I'll wait a bit more though to give others
a chance to comment.

Thanks for reviewing!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html