netdev - RE: [PATCH net-next] tipc: allow one link per bearer to neighboring nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 6 May 2015 19:45:18 +0000
From:	Jon Maloy <jon.maloy@...csson.com>
To:	Holger Brunck <holger.brunck@...mile.com>,
	"davem@...emloft.net" <davem@...emloft.net>
CC:	Ying Xue <ying.xue@...driver.com>,
	Erik Hugne <erik.hugne@...csson.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [PATCH net-next] tipc: allow one link per bearer to neighboring
 nodes

Hi Holger,
I am trying to remember why you wanted to have this, especially since it
didn't change anything in practice, because MAX_BEARERS is still 2.

This limit has to be changed, since we may want to have e.g. dual Ethernet
links to some nodes and single UDP links to others (but never the same)

Despite this, I can find good reasons to not allow more than two links 
between a node pair. (In particular, the failover mechanism becomes 
much more complex)

Can you please reiterate why you see a need for this?

Regards
///jon


> -----Original Message-----
> From: Holger Brunck [mailto:holger.brunck@...mile.com]
> Sent: Friday, November 14, 2014 12:33 PM
> To: davem@...emloft.net
> Cc: Jon Maloy; Holger Brunck; Ying Xue; Erik Hugne; netdev@...r.kernel.org
> Subject: [PATCH net-next] tipc: allow one link per bearer to neighboring
> nodes
> 
> There is no reason to limit the amount of possible links to a neighboring node
> to 2. If we have more then two bearers we can also establish more links.
> 
> Signed-off-by: Holger Brunck <holger.brunck@...mile.com>
> Reviewed-By: Jon Maloy <jon.maloy@...csson.com>
> cc: Ying Xue <ying.xue@...driver.com>
> cc: Erik Hugne <erik.hugne@...csson.com>
> cc: netdev@...r.kernel.org
> ---
>  net/tipc/link.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/net/tipc/link.c b/net/tipc/link.c index 1db162a..7cf8004 100644
> --- a/net/tipc/link.c
> +++ b/net/tipc/link.c
> @@ -224,9 +224,10 @@ struct tipc_link *tipc_link_create(struct tipc_node
> *n_ptr,
>  	char addr_string[16];
>  	u32 peer = n_ptr->addr;
> 
> -	if (n_ptr->link_cnt >= 2) {
> +	if (n_ptr->link_cnt >= MAX_BEARERS) {
>  		tipc_addr_string_fill(addr_string, n_ptr->addr);
> -		pr_err("Attempt to establish third link to %s\n", addr_string);
> +		pr_err("Attempt to establish %uth link to %s. Max %u
> allowed.\n",
> +			n_ptr->link_cnt, addr_string, MAX_BEARERS);
>  		return NULL;
>  	}
> 
> --
> 2.1.2

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html