netdev - Re: [PATCH] stmmac: call local_irq_save other than disable_irq in poll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 06 May 2015 10:02:06 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	sonic.adi@...il.com
Cc:	peppe.cavallaro@...com, netdev@...r.kernel.org,
	adi-buildroot-devel@...ts.sourceforge.net, sonic.zhang@...log.com
Subject: Re: [PATCH] stmmac: call local_irq_save other than disable_irq in
 poll_controller

From: Sonic Zhang <sonic.adi@...il.com>
Date: Wed, 6 May 2015 11:53:53 +0800

> When I debug Linux kernel via KGDB over Ethernet, KGDB calls netpoll
> API and stmmac_poll_controller to send UDP packets with all interrupts
> disabled. KGDB assumes all interrupts keeps disabled when it is active
> and doing UDP data transmission. Enabling interrupts in
> stmmac_poll_controller causes KGDB re-enter exception and system halt.

If KGDB has disabled local cpu interrupts, that cannot happen.

What stmmac_poll_controller() is doing is enabling a specific interupt
source, not "interrupts" generally.  The latter is what KGDB can
specifically control and should care about.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html