netdev - Re: [PATCH v2 net-next 5/5] net: Add GRE keyid in flow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 12 May 2015 09:06:17 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Tom Herbert <tom@...bertland.com>
Cc:	"David S. Miller" <davem@...emloft.net>,
	Linux Kernel Network Developers <netdev@...r.kernel.org>
Subject: Re: [PATCH v2 net-next 5/5] net: Add GRE keyid in flow_keys

On Tue, 2015-05-12 at 10:51 -0400, Tom Herbert wrote:

> 
> I don't see these errors with sparse. How are you running it?
> 
> Thanks,
> Tom

root@...mazet-glaptop2:/usr/src/net-next# sparse --version
0.4.5-rc1
root@...mazet-glaptop2:/usr/src/net-next# make C=2 CF=-D__CHECK_ENDIAN__
M=net/ipv4
  CHECK   net/ipv4/route.c
  CHECK   net/ipv4/inetpeer.c
  CHECK   net/ipv4/protocol.c
  CHECK   net/ipv4/ip_input.c
  CHECK   net/ipv4/ip_fragment.c
  CHECK   net/ipv4/ip_forward.c
  CHECK   net/ipv4/ip_options.c
  CHECK   net/ipv4/ip_output.c
...
  CHECK   net/ipv4/tcp_offload.c
net/ipv4/tcp_offload.c:139:60: warning: incorrect type in argument 2
(different base types)
net/ipv4/tcp_offload.c:139:60:    expected restricted __wsum [usertype]
res
net/ipv4/tcp_offload.c:139:60:    got fouled restricted __sum16
include/linux/skbuff.h:3362:14: warning: incorrect type in assignment
(different base types)
include/linux/skbuff.h:3362:14:    expected unsigned short [unsigned]
[usertype] csum
include/linux/skbuff.h:3362:14:    got restricted __sum16
include/linux/skbuff.h:3367:16: warning: incorrect type in return
expression (different base types)
include/linux/skbuff.h:3367:16:    expected restricted __sum16
include/linux/skbuff.h:3367:16:    got unsigned short [unsigned]
[usertype] csum
net/ipv4/tcp_offload.c:173:52: warning: incorrect type in argument 2
(different base types)
net/ipv4/tcp_offload.c:173:52:    expected restricted __wsum [usertype]
res
net/ipv4/tcp_offload.c:173:52:    got fouled restricted __sum16
include/linux/skbuff.h:3362:14: warning: incorrect type in assignment
(different base types)
include/linux/skbuff.h:3362:14:    expected unsigned short [unsigned]
[usertype] csum
include/linux/skbuff.h:3362:14:    got restricted __sum16
include/linux/skbuff.h:3367:16: warning: incorrect type in return
expression (different base types)
include/linux/skbuff.h:3367:16:    expected restricted __sum16
include/linux/skbuff.h:3367:16:    got unsigned short [unsigned]
[usertype] csum
  CHECK   net/ipv4/gre_offload.c
include/linux/skbuff.h:3362:14: warning: incorrect type in assignment
(different base types)
include/linux/skbuff.h:3362:14:    expected unsigned short [unsigned]
[usertype] csum
include/linux/skbuff.h:3362:14:    got restricted __sum16
include/linux/skbuff.h:3367:16: warning: incorrect type in return
expression (different base types)
include/linux/skbuff.h:3367:16:    expected restricted __sum16
include/linux/skbuff.h:3367:16:    got unsigned short [unsigned]
[usertype] csum

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html