netdev - Re: [PATCH net v3] rtnl/bond: don't send rtnl msg for unregistered iface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 12 May 2015 18:14:02 +0200
From:	Jiri Pirko <jiri@...nulli.us>
To:	Nicolas Dichtel <nicolas.dichtel@...nd.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org, j.vosburgh@...il.com,
	vfalico@...il.com, gospo@...ulusnetworks.com
Subject: Re: [PATCH net v3] rtnl/bond: don't send rtnl msg for unregistered
 iface

Tue, May 12, 2015 at 06:10:56PM CEST, nicolas.dichtel@...nd.com wrote:
>Le 12/05/2015 17:58, Jiri Pirko a écrit :
>>Tue, May 12, 2015 at 05:17:45PM CEST, nicolas.dichtel@...nd.com wrote:
>[snip]
>>>First, nobody seems to care about NETDEV_CHANGEINFODATA (commit
>>>d4261e565000 says that it was put only to notify userspace). Hence, we can
>>>call directly rtmsg_ifinfo().
>>
>>Please leave this notifier here. Will be needed in very near future for
>>LAG offloading purposes.
>Ok.
>
>>
>>>Secondly, prevent in rtmsg_ifinfo() to send notifications to userspace
>>>about unregistered interfaces.
>>
>>I'm not sure about this. Why caller of rtmsg_ifinfo don't take care of
>>it? Seems more logical to me.
>Simply to avoid code duplication and ensure the bug will not show up in the
>future. The existing bug shows that it's easy to forget that check.

I don't know, seems to me more like curing consequence, not the cause.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html