lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 14 May 2015 14:02:30 +0800 From: Herbert Xu <herbert@...dor.apana.org.au> To: Eric Dumazet <eric.dumazet@...il.com> Cc: David Miller <davem@...emloft.net>, Thomas Graf <tgraf@...g.ch>, netdev <netdev@...r.kernel.org>, Ying Xue <ying.xue@...driver.com> Subject: netlink: Kill bogus lock_sock in netlink_insert On Thu, May 14, 2015 at 01:58:24PM +0800, Herbert Xu wrote: > > This patch also removes a bogus socket lock introduced by that > very same patch. This bogus socket lock is still there in the current tree. ---8<--- The commit c5adde9468b0714a051eac7f9666f23eb10b61f7 ("netlink: eliminate nl_sk_hash_lock") added a lock_sock to netlink_insert with no justifications whatsoever. This patch kills it. Signed-off-by: Herbert Xu <herbert@...dor.apana.org.au> diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c index ec4adbd..9460561 100644 --- a/net/netlink/af_netlink.c +++ b/net/netlink/af_netlink.c @@ -1063,8 +1063,6 @@ static int netlink_insert(struct sock *sk, u32 portid) struct netlink_table *table = &nl_table[sk->sk_protocol]; int err; - lock_sock(sk); - err = -EBUSY; if (nlk_sk(sk)->portid) goto err; @@ -1085,7 +1083,6 @@ static int netlink_insert(struct sock *sk, u32 portid) } err: - release_sock(sk); return err; } -- Email: Herbert Xu <herbert@...dor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists