netdev - Re: [PATCH net-next v3] tcp: add rfc3168, section 6.1.1.1. fallback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 20 May 2015 11:13:08 -0700
From:	Vijay Subramanian <subramanian.vijay@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	Daniel Borkmann <daniel@...earbox.net>,
	netdev <netdev@...r.kernel.org>, fw@...len.de,
	mirja.kuehlewind@....ee.ethz.ch, trammell@....ee.ethz.ch,
	Eric Dumazet <edumazet@...gle.com>,
	Dave Taht <dave.taht@...il.com>
Subject: Re: [PATCH net-next v3] tcp: add rfc3168, section 6.1.1.1. fallback

Hi Daniel,

With this commit, ifconfig does not show any of the interfaces and I
don't have any connectivity as a result.
Can you double check this?

Thanks!
Vijay

On 19 May 2015 at 13:54, David Miller <davem@...emloft.net> wrote:
> From: Daniel Borkmann <daniel@...earbox.net>
> Date: Tue, 19 May 2015 21:33:42 +0200
>
>> This work as a follow-up of commit f7b3bec6f516 ("net: allow setting ecn
>> via routing table") and adds RFC3168 section 6.1.1.1. fallback for outgoing
>> ECN connections. In other words, this work adds a retry with a non-ECN
>> setup SYN packet, as suggested from the RFC on the first timeout:
>>
>>   [...] A host that receives no reply to an ECN-setup SYN within the
>>   normal SYN retransmission timeout interval MAY resend the SYN and
>>   any subsequent SYN retransmissions with CWR and ECE cleared. [...]
>  ...
>> Reference: https://www.ietf.org/proceedings/92/slides/slides-92-iccrg-1.pdf
>> Reference: https://www.ietf.org/proceedings/89/slides/slides-89-tsvarea-1.pdf
>> Signed-off-by: Daniel Borkmann <daniel@...earbox.net>
>> Signed-off-by: Florian Westphal <fw@...len.de>
>> Signed-off-by: Mirja Kühlewind <mirja.kuehlewind@....ee.ethz.ch>
>> Signed-off-by: Brian Trammell <trammell@....ee.ethz.ch>
>> Cc: Eric Dumazet <edumazet@...gle.com>
>> Cc: Dave Täht <dave.taht@...il.com>
>> ---
>>  v2 -> v3:
>>   - Very sorry. Typo happened in Dave's name since v1, getting it right
>>     this time, no bad intentions. ;)
>>  v1 -> v2:
>>   - Added suggestion from Eric to let ecn_flags be cleared eventually in
>>     tcp_ecn_rcv_synack(), thanks!
>>   - Rest as is.
>
> Applied, thanks everyone.
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html