netdev - Re: [v2, 1/2] adm8211: fix checkpatch errors for indentation and new line

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 26 May 2015 10:48:02 +0000 (UTC)
From:	Kalle Valo <kvalo@...eaurora.org>
To:	Okash Khawaja <okash.khawaja@...il.com>
Cc:	linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [v2,
 1/2] adm8211: fix checkpatch errors for indentation and new line


> This patch fixes these checkpatch.pl errors around a single switch-case
> block:
> 
> ERROR: switch and case should be at the same indent
> ERROR: trailing statements should be on next line
> 
> More specifically, the fix has been applied to the five occurances of
> the errors listed below.
> 
> ERROR: switch and case should be at the same indent
> #1100: FILE: adm8211.c:1100:
> +               switch (cline) {
> [...]
> +                 default: reg |= (0x0 << 14);
> 
> ERROR: trailing statements should be on next line
> #1101: FILE: adm8211.c:1101:
> +               case  0x8: reg |= (0x1 << 14);
> 
> ERROR: trailing statements should be on next line
> #1103: FILE: adm8211.c:1103:
> +               case 0x16: reg |= (0x2 << 14);
> 
> ERROR: trailing statements should be on next line
> #1105: FILE: adm8211.c:1105:
> +               case 0x32: reg |= (0x3 << 14);
> 
> ERROR: trailing statements should be on next line
> #1107: FILE: adm8211.c:1107:
> +                 default: reg |= (0x0 << 14);
> 
> 
> Signed-off-by: Okash Khawaja <okash.khawaja@...il.com>

Thanks, 2 patches applied to wireless-drivers-next.git:

f5c65f38912e adm8211: fix checkpatch errors for indentation and new line
fe0a483ecf44 adm8211: fixed the possible pci cache line sizes inside switch-case

Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html