netdev - Re: [RFC 1/3] net: dsa: add basic support for VLAN ndo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 29 May 2015 18:57:45 -0400 (EDT)
From:	Vivien Didelot <vivien.didelot@...oirfairelinux.com>
To:	Guenter Roeck <linux@...ck-us.net>,
	Scott Feldman <sfeldma@...il.com>
Cc:	Or Gerlitz <gerlitz.or@...il.com>, netdev <netdev@...r.kernel.org>,
	Florian Fainelli <f.fainelli@...il.com>,
	Andrew Lunn <andrew@...n.ch>,
	Jérome Oufella 
	<jerome.oufella@...oirfairelinux.com>,
	Chris Healy <cphealy@...il.com>, Jiri Pirko <jiri@...nulli.us>
Subject: Re: [RFC 1/3] net: dsa: add basic support for VLAN ndo


On May 29, 2015, at 6:15 PM, Guenter Roeck linux@...ck-us.net wrote:
> On 05/29/2015 08:51 AM, Or Gerlitz wrote:
>> On Fri, May 29, 2015 at 6:38 PM, Vivien Didelot <vivien.didelot@...oirfairelinux.com> wrote:
>>> Hi,
>>>
>>> ----- On May 29, 2015, at 11:24 AM, Or Gerlitz gerlitz.or@...il.com wrote:
>>>
>>>> On Fri, May 29, 2015 at 12:37 AM, Vivien Didelot
>>>> <vivien.didelot@...oirfairelinux.com> wrote:
>>>>> @@ -854,7 +922,9 @@ int dsa_slave_create(struct dsa_switch *ds, struct device
>>>>> *parent,
>>>>>          if (slave_dev == NULL)
>>>>>                  return -ENOMEM;
>>>>>
>>>>> -       slave_dev->features = master->vlan_features;
>>>>> +       slave_dev->features = master->vlan_features |
>>>>> +               NETIF_F_VLAN_FEATURES |
>>>>> +               NETIF_F_HW_SWITCH_OFFLOAD;
>>>>
>>>> wait... didn't commit 7889cbee8357aaed85898d028829dfb4f75bae2c  remove
>>>> NETIF_F_HW_SWITCH_OFFLOAD?
>>>
>>> Indeed, note that this RFC is based on v4.1-rc3. This will become unneeded I
>>> guess.
>>
>>
>> You should rebase networking patches proposed for the next kernel
>> against the net-next tree.
>>
>>> BTW, given the commit message, I didn't really understand why?
>>
>> M2, I thought it was unsuccessful commit message and made a comment to
>> the maintainer, he didn't accept it.
>>
> Vivien,
> 
> sorry for asking for an early set of your patches. Obviously the idea was not
> to create trouble for anyone :-(. I wasn't aware that netdev only accepts
> patches
> which apply to the latest net-next, even if sent as RFC. My fault, I guess.
> 
> Maybe next time we can share patches in private first if we have a similar
> situation ?

Guenter,

I agree. Maybe sending this to netdev too was a bad idea, my bad.

Scott,

Can I ask details about this NETIF_F_HW_SWITCH_OFFLOAD flag? Why is it
unneeded?

Thanks,
-v
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html