netdev - Re: [PATCH] can: mcp251x: not correct register address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 30 May 2015 09:41:06 +0200
From:	Jakub Kicinski <moorray3@...pl>
To:	Tomas Krcka <tomas.krcka@...roup.cz>
Cc:	linux-can@...r.kernel.org, andri.yngvason@...el.com,
	mkl@...gutronix.de, himangi774@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH] can: mcp251x: not correct register address

On Mon, 25 May 2015 08:57:48 +0200, Tomas Krcka wrote:
> This patch corrects addresses of acceptance filters.
> These registers are not in use, but values should be correct.
> Tested with MCP2515 and am3352 and also checked datasheets for MCP2515
> and MCP2510.
> 
> Signed-off-by: Tomas Krcka <tomas.krcka@...roup.cz>
> 
> ---
>   drivers/net/can/spi/mcp251x.c |    9 +++++----
>   1 files changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/net/can/spi/mcp251x.c b/drivers/net/can/spi/mcp251x.c
> index bf63fee..c1a95a3 100644
> --- a/drivers/net/can/spi/mcp251x.c
> +++ b/drivers/net/can/spi/mcp251x.c
> @@ -190,10 +190,11 @@
>   #define RXBEID0_OFF 4
>   #define RXBDLC_OFF  5
>   #define RXBDAT_OFF  6
> -#define RXFSIDH(n) ((n) * 4)
> -#define RXFSIDL(n) ((n) * 4 + 1)
> -#define RXFEID8(n) ((n) * 4 + 2)
> -#define RXFEID0(n) ((n) * 4 + 3)
> +#define RXFSID(n) ((n < 3) ? 0 : 4)
> +#define RXFSIDH(n) ((n) * 4 + RXFSID(n))
> +#define RXFSIDL(n) ((n) * 4 + 1 + RXFSID(n))
> +#define RXFEID8(n) ((n) * 4 + 2 + RXFSID(n))
> +#define RXFEID0(n) ((n) * 4 + 3 + RXFSID(n))
>   #define RXMSIDH(n) ((n) * 4 + 0x20)
>   #define RXMSIDL(n) ((n) * 4 + 0x21)
>   #define RXMEID8(n) ((n) * 4 + 0x22)

I think your patch was corrupted.  It doesn't apply because you have
extra space before each surviving #define.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html