netdev - Re: [PATCH net] net/mlx4: fix typo in mlx4_set_vf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Tue, 2 Jun 2015 08:58:25 +0300
From:	Or Gerlitz <gerlitz.or@...il.com>
To:	clsoto@...ux.vnet.ibm.com
Cc:	David Miller <davem@...emloft.net>,
	Linux Netdev List <netdev@...r.kernel.org>,
	Amir Vadai <amirv@...lanox.com>, jackm@...lanox.com,
	brking@...ux.vnet.ibm.com
Subject: Re: [PATCH net] net/mlx4: fix typo in mlx4_set_vf_mac

On Mon, Jun 1, 2015 at 5:41 PM,  <clsoto@...ux.vnet.ibm.com> wrote:
> fix typo in mlx4_set_vf_mac
>
> Signed-off-by: Carol L Soto <clsoto@...ux.vnet.ibm.com>
> ---
>  drivers/net/ethernet/mellanox/mlx4/cmd.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/drivers/net/ethernet/mellanox/mlx4/cmd.c
> +++ b/drivers/net/ethernet/mellanox/mlx4/cmd.c
> @@ -2687,7 +2687,7 @@ int mlx4_set_vf_mac(struct mlx4_dev *dev
>         port = mlx4_slaves_closest_port(dev, slave, port);
>         s_info = &priv->mfunc.master.vf_admin[slave].vport[port];
>         s_info->mac = mac;
> -       mlx4_info(dev, "default mac on vf %d port %d to %llX will take afect only after vf restart\n",
> +       mlx4_info(dev, "default mac on vf %d port %d to %llX will take effect only after vf restart\n",
>                   vf, port, s_info->mac);
>         return 0;
>  }

Hi Carol,

Thanks for the fixes, will look on the other two today and provide feedback.

As for this one: please re-send the patch and target it to net-next
(i.e have [PATCH net-next] on the subject line and generate it against
the net-next tree
git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git).

Also, we use some conventions in our commits, will be happy if you can
pick on them:

-- have "net/mlx4_core:" prefix
-- use capital letter in the 1st word of the subject line, that is

so [PATCH net] net/mlx4: fix typo in mlx4_set_vf_mac

becomes

[PATCH net-next] net/mlx4_core: Fix typo in mlx4_set_vf_mac

You can add my ack

Acked-by: Or Gerlitz <ogerlitz@...lanox.com>

Or.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html