netdev - Re: [PATCH v2 1/2] net/xen-netfront: Correct printf format in xennet_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 04 Jun 2015 11:43:07 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	julien.grall@...rix.com
Cc:	joe@...ches.com, xen-devel@...ts.xenproject.org,
	ian.campbell@...rix.com, stefano.stabellini@...citrix.com,
	linux-kernel@...r.kernel.org, david.vrabel@...rix.com,
	konrad.wilk@...cle.com, boris.ostrovsky@...cle.com,
	netdev@...r.kernel.org
Subject: Re: [PATCH v2 1/2] net/xen-netfront: Correct printf format in
 xennet_get_responses

From: Julien Grall <julien.grall@...rix.com>
Date: Thu, 4 Jun 2015 13:45:00 +0100

> On 03/06/15 18:06, Joe Perches wrote:
>> On Wed, 2015-06-03 at 17:55 +0100, Julien Grall wrote:
>>> rx->status is an int16_t, print it using %d rather than %u in order to
>>> have a meaningful value when the field is negative.
>> []
>>> diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c
>> []
>>> @@ -733,7 +733,7 @@ static int xennet_get_responses(struct netfront_queue *queue,
>>>  		if (unlikely(rx->status < 0 ||
>>>  			     rx->offset + rx->status > PAGE_SIZE)) {
>>>  			if (net_ratelimit())
>>> -				dev_warn(dev, "rx->offset: %x, size: %u\n",
>>> +				dev_warn(dev, "rx->offset: %x, size: %d\n",
>> 
>> If you're going to do this, perhaps it'd be sensible to
>> also change the %x to %#x or 0x%x so that people don't
>> mistake offset without an [a-f] for decimal.
> 
> Good idea. I will resend a version of this series.
> 
> David, can I keep you Reviewed-by for this change?

Sure.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html