lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 07 Jun 2015 00:13:51 -0700 (PDT) From: David Miller <davem@...emloft.net> To: hofrat@...dl.org Cc: romieu@...zoreil.com, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] wan: dscc4: use msecs_to_jiffies for conversions From: Nicholas Mc Guire <hofrat@...dl.org> Date: Sat, 6 Jun 2015 10:41:06 +0200 > API compliance scanning with coccinelle flagged: > ./drivers/net/wan/dscc4.c:1036:1-33: > WARNING: timeout (10) seems HZ dependent > ./drivers/net/wan/dscc4.c:554:2-34: > WARNING: timeout (10) seems HZ dependent > ./drivers/net/wan/dscc4.c:599:2-34: > WARNING: timeout (10) seems HZ dependent > > Numeric constants passed to schedule_timeout_*() make the effective > timeout HZ dependent which does not seem to be the intent here. > Fixed up by converting the constant to jiffies with msecs_to_jiffies() > > Signed-off-by: Nicholas Mc Guire <hofrat@...dl.org> Whoever wrote these things probably wanted whatever this amounts to when HZ=100, so that is the only valid transformation you can make to fix this up here. Otherwise you seriously risk breaking the driver. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists