netdev - Re: [PATCH 3/3] net: dsa: Allow configuration of CPU & DSA port speeds/duplex

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 15 Jun 2015 10:32:50 -0700
From:	Florian Fainelli <f.fainelli@...il.com>
To:	Guenter Roeck <linux@...ck-us.net>, Andrew Lunn <andrew@...n.ch>,
	David Miller <davem@...emloft.net>
CC:	Cory Tusar <cory.tusar@...1solutions.com>,
	netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH 3/3] net: dsa: Allow configuration of CPU & DSA port speeds/duplex

On 12/06/15 11:29, Guenter Roeck wrote:
[snip]

static int dsa_switch_setup_one(struct dsa_switch *ds, struct
>>> device *parent)
>>>   {
>>>       struct dsa_switch_driver *drv = ds->drv;
>>> @@ -204,6 +234,7 @@ static int dsa_switch_setup_one(struct dsa_switch
>>> *ds, struct device *parent)
>>>               }
>>>               dst->cpu_switch = index;
>>>               dst->cpu_port = i;
>>> +            ds->cpu_port_mask |= 1 << i;
>>
>> Same question as Guenter here, I assume this is because you plan on
>> having multiple CPU ports connected to the switch and this makes it
>> easier to deal with, is that right?
>>
> 
> If so, should that be done in a separate patch set ?

I think it would be clearer that way, yes.
-- 
Florian
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html