netdev - Re: [RFC PATCH net-next v2 2/5] net: add phys ID compare helper to test if two IDs are the same

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 18 Jun 2015 17:11:14 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	sfeldma@...il.com, netdev@...r.kernel.org
CC:	jiri@...nulli.us, simon.horman@...ronome.com,
	roopa@...ulusnetworks.com, ronen.arad@...el.com,
	john.r.fastabend@...el.com, andrew@...n.ch, f.fainelli@...il.com,
	linux@...ck-us.net, davidch@...adcom.com,
	stephen@...workplumber.org
Subject: Re: [RFC PATCH net-next v2 2/5] net: add phys ID compare helper to
 test if two IDs are the same

Hello.

On 6/18/2015 12:53 AM, sfeldma@...il.com wrote:

> From: Scott Feldman <sfeldma@...il.com>

> Signed-off-by: Scott Feldman <sfeldma@...il.com>
> ---
>   include/linux/netdevice.h |    7 +++++++
>   net/switchdev/switchdev.c |    8 ++------
>   2 files changed, 9 insertions(+), 6 deletions(-)

> diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
> index 7be616e1..63090ce 100644
> --- a/include/linux/netdevice.h
> +++ b/include/linux/netdevice.h
> @@ -766,6 +766,13 @@ struct netdev_phys_item_id {
>   	unsigned char id_len;
>   };
>
> +static inline bool netdev_phys_item_id_same(struct netdev_phys_item_id *a,
> +					    struct netdev_phys_item_id *b)
> +{
> +	return ((a->id_len == b->id_len) &&
> +		(memcmp(a->id, b->id, a->id_len) == 0));

    Parens around the *return* expression not needed (and neither the ones 
around ==).

[...]

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html