lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 19 Jun 2015 11:48:28 -0400 (EDT) From: Vivien Didelot <vivien.didelot@...oirfairelinux.com> To: Andrew Lunn <andrew@...n.ch> Cc: Florian Fainelli <f.fainelli@...il.com>, David <davem@...emloft.net>, Guenter Roeck <linux@...ck-us.net>, Cory Tusar <cory.tusar@...1solutions.com>, netdev <netdev@...r.kernel.org> Subject: Re: [PATCH 3/3] net: dsa: Allow configuration of CPU & DSA port speeds/duplex Hi Andrew, On Jun 19, 2015, at 11:05 AM, Andrew Lunn andrew@...n.ch wrote: >> Yes I do have debug too, but via sysfs (with eventually write access) for: >> GLOBAL1, GLOBAL2, cpu port registers, SerDes registers, PVIDs, and VTU. >> Not really standard though. > > We should really get an implementation into mainline. There is no > point us all implementing our own. I couldn't agree more. It's important for development to have read/write access to the switch registers, bypassing the userspace tools. > You say your code is not really standard. Do you think it would get > rejected if it was submitted? The rules for debugfs are much more > relaxed, so what i have should be acceptable. Yes my code will definitely be rejected. I have a net/dsa/debug.c file that creates a debug directory under /sys/devices/platform/dsa.0/ with global1, global2, cpu_port, serdes, pvid, and vtu sysfs attributes. Read and write access to debugfs sounds better IMO. Thanks, -v -- To unsubscribe from this list: send the line "unsubscribe netdev" in
Powered by blists - more mailing lists