netdev - Re: [PATCHv2 net-next] net: fec: Ensure clocks are enabled while using mdio bus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 20 Jun 2015 19:58:17 +0200
From:	Andrew Lunn <andrew@...n.ch>
To:	Fabio Estevam <festevam@...il.com>
Cc:	David Miller <davem@...emloft.net>,
	Nimrod Andy <B38611@...escale.com>,
	Duan Andy <fugang.duan@...escale.com>,
	Cory Tusar <cory.tusar@...1solutions.com>,
	netdev <netdev@...r.kernel.org>
Subject: Re: [PATCHv2 net-next] net: fec: Ensure clocks are enabled while
 using mdio bus

On Sat, Jun 20, 2015 at 02:47:20PM -0300, Fabio Estevam wrote:
> On Sat, Jun 20, 2015 at 1:15 PM, Andrew Lunn <andrew@...n.ch> wrote:
> 
> > @@ -1764,6 +1765,11 @@ static int fec_enet_mdio_read(struct mii_bus *bus, int mii_id, int regnum)
> >  {
> >         struct fec_enet_private *fep = bus->priv;
> >         unsigned long time_left;
> > +       int ret;
> > +
> > +       ret = clk_prepare_enable(fep->clk_ipg);
> > +       if (ret)
> > +               return 0xffff;
> 
> Why don`t you return ret instead?

ret would also work.

v3 to follow soon.

   Andrew
--
To unsubscribe from this list: send the line "unsubscribe netdev" in