lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 24 Jun 2015 09:48:15 +0200 From: Geert Uytterhoeven <geert@...ux-m68k.org> To: David Miller <davem@...emloft.net> Cc: Geert Uytterhoeven <geert+renesas@...der.be>, Sergei Shtylyov <sergei.shtylyov@...entembedded.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, Linux-sh list <linux-sh@...r.kernel.org> Subject: Re: [PATCH 1/2] sh_eth: Remove obsolete r7s72100-ether platform_device_id entry Hi David, On Wed, Jun 24, 2015 at 9:55 AM, David Miller <davem@...emloft.net> wrote: > From: Geert Uytterhoeven <geert+renesas@...der.be> > Date: Tue, 23 Jun 2015 15:01:01 +0200 > >> Since commit 05104c266ae9a167 ("ARM: shmobile: r7s72100: genmai: Remove >> legacy board file"), r7s72100 is only supported in generic DT-only ARM >> multi-platform builds. The driver doesn't need to match platform >> devices by name anymore, hence remove the corresponding >> platform_device_id entry. >> >> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be> > > These two changes are incomplete, please compile test your changes and > look for warnings: > > drivers/net/ethernet/renesas/sh_eth.c:493:31: warning: ‘r8a779x_data’ defined but not used [-Wunused-variable] > drivers/net/ethernet/renesas/sh_eth.c:803:31: warning: ‘r7s72100_data’ defined but not used [-Wunused-variable] You're right. They're still used for DT matching, but I missed that sh_eth_match_table[] is protected by #ifdef CONFIG_OF, which is always set on ARM these days. Sorry about that, will fix. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists