lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 3 Jul 2015 22:42:13 +0200 From: Florian Westphal <fw@...len.de> To: Julien Grall <julien.grall@...rix.com> Cc: stephen@...workplumber.org, davem@...emloft.net, bridge@...ts.linux-foundation.org, netdev@...r.kernel.org, xen-devel@...ts.xenproject.org, linux-kernel@...r.kernel.org, Bernhard Thaler <bernhard.thaler@...et.at>, Pablo Neira Ayuso <pablo@...filter.org>, fw@...len.de, ian.campbell@...rix.com, wei.liu2@...rix.com Subject: Re: [PATCH] net/bridge: Add missing in6_dev_put in br_validate_ipv6 Julien Grall <julien.grall@...rix.com> wrote: > The commit efb6de9b4ba0092b2c55f6a52d16294a8a698edd "netfilter: bridge: > forward IPv6 fragmented packets" introduced a new function > br_validate_ipv6 which take a reference on the inet6 device. Although, > the reference is not released at the end. > > This will result to the impossibility to destroy any netdevice using > ipv6 and bridge. > > Spotted while trying to destroy a Xen guest on the upstream Linux: > "unregister_netdevice: waiting for vif1.0 to become free. Usage count = 1" Ugh :-/ I think it makes more sense to use __in6_dev_get() instead which doesn't take a reference. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists