netdev - Re: [PATCH 6/7] hvsock: introduce Hyper-V VM Sockets feature

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 07 Jul 2015 11:37:56 +0200
From:	Paul Bolle <pebolle@...cali.nl>
To:	Dexuan Cui <decui@...rosoft.com>
Cc:	gregkh@...uxfoundation.org, davem@...emloft.net,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	driverdev-devel@...uxdriverproject.org, olaf@...fle.de,
	apw@...onical.com, jasowang@...hat.com, kys@...rosoft.com,
	haiyangz@...rosoft.com
Subject: Re: [PATCH 6/7] hvsock: introduce Hyper-V VM Sockets feature

Just two nits.

On ma, 2015-07-06 at 07:47 -0700, Dexuan Cui wrote:
> --- /dev/null
> +++ b/net/hv_sock/Kconfig

> +config HYPERV_SOCK
> +	tristate "Microsoft Hyper-V Socket (EXPERIMENTAL)"
> +	depends on HYPERV
> +	default m
> +	help
> +	  Hyper-V Socket is a socket protocol similar to TCP, allowing
> +	  communication between a Linux guest and the host.
> +
> +	  To compile this driver as a module, choose M here: the module
> +	  will be called hv_sock. If unsure, say N.

It's a bit odd to advise to say N if one is unsure and set the default
to 'm' at the same time.

> --- /dev/null
> +++ b/net/hv_sock/af_hvsock.c

> +static int hvsock_init(void)
> +{
> +	[...]
> +}
> +
> +static void hvsock_exit(void)
> +{
> +	[...]
> +}
> +
> +module_init(hvsock_init);
> +module_exit(hvsock_exit);

Any specific reason not to mark these functions __init and __exit?

Thanks,


Paul Bolle
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html