[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 07 Jul 2015 20:25:18 +0300
From: Vasily Averin <vvs@...tuozzo.com>
To: Cong Wang <xiyou.wangcong@...il.com>
CC: "David S. Miller" <davem@...emloft.net>,
Linux Kernel Network Developers <netdev@...r.kernel.org>,
intel-wired-lan <intel-wired-lan@...ts.osuosl.org>,
Jeff Kirsher <jeffrey.t.kirsher@...el.com>,
Hannes Frederic Sowa <hannes@...essinduktion.org>
Subject: Re: [PATCH 3/3] ipmr_free_table() should be called under taken rtnl_lock
On 07.07.2015 20:13, Cong Wang wrote:
> On Tue, Jul 7, 2015 at 8:53 AM, Vasily Averin <vvs@...tuozzo.com> wrote:
>> ipmr_free_table() calls unregister_netdevice_many() inside
>> and changes net_todo_list protected by rtnl_lock
>
> Did you see any real bug?
No, it was result of manual code review.
> ipmr_free_table() is called in failure path, in this case there is no
> device registered yet, so unregister should be just a nop?
However may be it's better to mark this place for future anyway?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists