netdev - Re: [PATCH net,v2] ip_tunnel: fix ipv4 pmtu check to honor inner ip header df

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 7 Jul 2015 15:07:46 -0700
From:	Pravin Shelar <pshelar@...ira.com>
To:	Timo Teräs <timo.teras@....fi>
Cc:	netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net,v2] ip_tunnel: fix ipv4 pmtu check to honor inner ip
 header df

On Mon, Jul 6, 2015 at 10:34 PM, Timo Teräs <timo.teras@....fi> wrote:
> Frag needed should be sent only if the inner header asked
> to not fragment. Currently fragmentation is broken if the
> tunnel has df set, but df was not asked in the original
> packet. The tunnel's df needs to be still checked to update
> internally the pmtu cache.
>
> Commit 23a3647bc4f93bac broke it, and this commit fixes
> the ipv4 df check back to the way it was.
>
> Fixes: 23a3647bc4f93bac ("ip_tunnels: Use skb-len to PMTU check.")
> Cc: Pravin B Shelar <pshelar@...ira.com>
> Signed-off-by: Timo Teräs <timo.teras@....fi>
> ---
> Should go to -stable queues (3.12.y and newer).
>
> v2: revised commit message wording a bit, and added
> signed-off-by line that was forgotten accidentally.
>

Acked-by: Pravin B Shelar <pshelar@...ira.com>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html