netdev - Re: [PATCH net-next v4 1/4] net core: Add protodown support.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 8 Jul 2015 18:08:42 -0700
From:	Anuradha Karuppiah <anuradhak@...ulusnetworks.com>
To:	Jonathan Toppins <jtoppins@...ulusnetworks.com>
Cc:	"David S. Miller" <davem@...emloft.net>,
	Scott Feldman <sfeldma@...il.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	Roopa Prabhu <roopa@...ulusnetworks.com>,
	Andy Gospodarek <gospo@...ulusnetworks.com>,
	Wilson Kok <wkok@...ulusnetworks.com>
Subject: Re: [PATCH net-next v4 1/4] net core: Add protodown support.

On Wed, Jul 8, 2015 at 4:07 PM, Jonathan Toppins
<jtoppins@...ulusnetworks.com> wrote:
> On 7/8/15 5:04 PM, anuradhak@...ulusnetworks.com wrote:
>>
>> diff --git a/include/uapi/linux/if.h b/include/uapi/linux/if.h
>> index 9cf2394..8d60fe7 100644
>> --- a/include/uapi/linux/if.h
>> +++ b/include/uapi/linux/if.h
>> @@ -156,6 +156,12 @@ enum {
>>         IF_LINK_MODE_DORMANT,   /* limit upward transition to dormant */
>>   };
>>
>> +/* proto_flags - port state information can be passed to the switch
>> driver and
>> + * used to determine the phys state of the switch port */
>> +enum {
>> +       IF_PROTOF_DOWN          = 1<<0  /* set switch port phys state down
>> */
>
>
> It might be better to use BIT(0) provided by linux/bitopts.h
>
>> +};
>> +
>
>
Ack.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html