netdev - Re: [PATCH v1 03/12] IB/ipoib: Return IPoIB devices matching connection parameters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 9 Jul 2015 12:57:31 +0300
From:	Haggai Eran <haggaie@...lanox.com>
To:	Jason Gunthorpe <jgunthorpe@...idianresearch.com>
CC:	Doug Ledford <dledford@...hat.com>, <linux-rdma@...r.kernel.org>,
	<netdev@...r.kernel.org>, Liran Liss <liranl@...lanox.com>,
	Guy Shapiro <guysh@...lanox.com>,
	Shachar Raindel <raindel@...lanox.com>,
	Yotam Kenneth <yotamke@...lanox.com>
Subject: Re: [PATCH v1 03/12] IB/ipoib: Return IPoIB devices matching connection
 parameters

On 09/07/2015 02:41, Jason Gunthorpe wrote:
> On Mon, Jun 22, 2015 at 03:42:32PM +0300, Haggai Eran wrote:
>> +		if (net_dev) {
>> +			ipoib_warn(priv, "matching net_dev found: %s\n",
>> +				   net_dev->name);
> 
> Is that a debug print?

Yes, I'm afraid it slipped in somehow. I'll remove it.

> 
>> +	default:
>> +		dev_warn(&dev->dev, "duplicate IP address detected\n");
>> +		/* Fall through */
> 
> Surely that needs some kind of rate limit?

I'll use dev_warn_ratelimited().

Thanks,
Haggai
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html