netdev - Re: [RFC net-next 22/22] openvswitch: Use regular GRE net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 16 Jul 2015 16:52:46 +0200
From:	Thomas Graf <tgraf@...g.ch>
To:	Simon Horman <simon.horman@...ronome.com>
Cc:	roopa@...ulusnetworks.com, rshearma@...cade.com,
	ebiederm@...ssion.com, hannes@...essinduktion.org,
	pshelar@...ira.com, jesse@...ira.com, davem@...emloft.net,
	daniel@...earbox.net, tom@...bertland.com, edumazet@...gle.com,
	jiri@...nulli.us, marcelo.leitner@...il.com,
	stephen@...workplumber.org, jpettit@...ira.com, kaber@...sh.net,
	netdev@...r.kernel.org, dev@...nvswitch.org
Subject: Re: [RFC net-next 22/22] openvswitch: Use regular GRE net_device
 instead of vport

On 07/16/15 at 05:59pm, Simon Horman wrote:
> On Fri, Jul 10, 2015 at 04:19:24PM +0200, Thomas Graf wrote:
> >  static void ipgre_tap_setup(struct net_device *dev)
> >  {
> >  	ether_setup(dev);
> > -	dev->netdev_ops		= &gre_tap_netdev_ops;
> >  	dev->priv_flags 	|= IFF_LIVE_ADDR_CHANGE;
> >  	ip_tunnel_setup(dev, gre_tap_net_id);
> > +
> > +	if (!strcmp(dev->name, GRE_TAP_FB_NAME))
> > +		dev->netdev_ops		= &gre_fb_netdev_ops;
> > +	else
> > +		dev->netdev_ops		= &gre_tap_netdev_ops;
> >  }
> >  
> >  static int ipgre_newlink(struct net *src_net, struct net_device *dev,
> 
> [snip]
> 
> Is there a side-effect of the above that if a user creates a gretap device
> whose name is "gretap0" then the device will use gre_fb_netdev_ops instead
> of gre_tap_netdev_ops. If so, does that imply a change in behaviour for
> gretap devices created with that name?

I'm inclined to change this and use an in-kernel API as well to
create the net_device just like VXLAN does in patch 21.

Pravin, what do you think?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html