netdev - drivers/net/phy/dp83867.c:167: possible bad if ?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 20 Jul 2015 12:37:38 +0000
From:	David Binderman <dcb314@...mail.com>
To:	"f.fainelli@...il.com" <f.fainelli@...il.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: drivers/net/phy/dp83867.c:167: possible bad if ?

Hello there,

drivers/net/phy/dp83867.c:167:57: warning: logical ‘or’ of collectively exhaustive tests is always true [-Wlogical-op]

Source code is

    if ((phydev->interface>= PHY_INTERFACE_MODE_RGMII_ID) ||
        (phydev->interface <= PHY_INTERFACE_MODE_RGMII_RXID)) {

Maybe

    if ((phydev->interface>= PHY_INTERFACE_MODE_RGMII_ID) &&
        (phydev->interface <= PHY_INTERFACE_MODE_RGMII_RXID)) {


Regards

David Binderman

 		 	   		  --
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html