lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 20 Jul 2015 12:56:33 -0700 (PDT) From: David Miller <davem@...emloft.net> To: razor@...ckwall.org Cc: netdev@...r.kernel.org, j.vosburgh@...il.com, gospo@...ulusnetworks.com, vfalico@...il.com, clsoto@...ux.vnet.ibm.com, ebiederm@...ssion.com, nikolay@...ulusnetworks.com Subject: Re: [PATCH net] bonding: fix destruction of bond with devices different from arphrd_ether From: Nikolay Aleksandrov <razor@...ckwall.org> Date: Wed, 15 Jul 2015 21:52:51 +0200 > From: Nikolay Aleksandrov <nikolay@...ulusnetworks.com> > > When the bonding is being unloaded and the netdevice notifier is > unregistered it executes NETDEV_UNREGISTER for each device which should > remove the bond's proc entry but if the device enslaved is not of > ARPHRD_ETHER type and is in front of the bonding, it may execute > bond_release_and_destroy() first which would release the last slave and > destroy the bond device leaving the proc entry and thus we will get the > following error (with dynamic debug on for bond_netdev_event to see the > events order): ... > Thus remove the proc entry manually if bond_release_and_destroy() is > used. Because of the checks in bond_remove_proc_entry() it's not a > problem for a bond device to change namespaces (the bug fixed by the > Fixes commit) but since commit > f9399814927ad ("bonding: Don't allow bond devices to change network > namespaces.") that can't happen anyway. > > Reported-by: Carol Soto <clsoto@...ux.vnet.ibm.com> > Signed-off-by: Nikolay Aleksandrov <nikolay@...ulusnetworks.com> > Fixes: a64d49c3dd50 ("bonding: Manage /proc/net/bonding/ entries from > the netdev events") Applied and queued up for -stable, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists