netdev - Re: Why return E2BIG from bpf map update?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 21 Jul 2015 11:40:04 +0200
From:	Daniel Borkmann <daniel@...earbox.net>
To:	Alexei Starovoitov <ast@...mgrid.com>
CC:	Alex Gartrell <alexgartrell@...il.com>,
	netdev <netdev@...r.kernel.org>
Subject: Re: Why return E2BIG from bpf map update?

On 07/21/2015 12:24 AM, Alexei Starovoitov wrote:
> On 7/20/15 3:15 PM, Alex Gartrell wrote:
>> The ship has probably sailed on this one, but it seems like ENOSPC
>> makes more sense than E2BIG.  Any chance of changing it so that poor
>> ebpf library maintainers in the future don't have to wonder how their
>> argument list got too big?
>
> sorry, too late.
> It's in tests and even document in bpf manpage:
> "E2BIG - indicates that the number of elements in the map reached the
> max_entries limit specified at map creation time."
> I read E2BIG as "too big" and not as "argument list is too long" :)

If some libraries do an strerror(3) on errno then it certainly sounds
a bit weird, "no space left on device" perhaps also a bit misleading.
The bpf(2) manpage was actually submitted/discussed longer time ago,
but I still didn't see it in Michael's tree yet, will ping him again.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html